Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default pipeline version in ks package #291

Merged
merged 1 commit into from
Nov 17, 2018
Merged

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 15, 2018

This change is Reviewable

@IronPan
Copy link
Member Author

IronPan commented Nov 15, 2018

/assign @Ark-kun

@vicaire vicaire removed their request for review November 16, 2018 03:45
@IronPan
Copy link
Member Author

IronPan commented Nov 16, 2018

/test presubmit-e2e-test

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 16, 2018

/lgtm

@IronPan
Copy link
Member Author

IronPan commented Nov 17, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IronPan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b8e275e into master Nov 17, 2018
@IronPan IronPan deleted the IronPan-patch-7 branch December 10, 2018 22:26
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
* Show Argo workflow URLs when test starts.

* We want gubernator to surface Argo UI URLs when the test starts rather
  than having to wait until it finishes.

* We do this by including the links in the started.json metadata.
* This will be surfaced in gubernator until finished.json is created.

Fix kubeflow#82

* Fix metadata.

* Fix tests.
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants